[PATCH] D30549: [X86][SSE] Lower 128-bit vectors to SIGN/ZERO_EXTEND_VECTOR_IN_REG ops.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: include/llvm/Target/TargetSelectionDAG.td:165
+  SDTCisInt<0>, SDTCisVec<0>, SDTCisInt<1>, SDTCisVec<1>,
+  SDTCisSameSizeAs<0,1>
+]>;
----------------
craig.topper wrote:
> Should this have SDTCisOpSmallerThanOp<1, 0> too?
Yes I'll add that as well.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2449
   }
   case ISD::SIGN_EXTEND: {
     EVT InVT = Op.getOperand(0).getValueType();
----------------
craig.topper wrote:
> Why no handling for ISD::SIGN_EXTEND_VECTOR_INREG?
We have no current test coverage that requires this - I'd prefer to add it as a followup if possible.


Repository:
  rL LLVM

https://reviews.llvm.org/D30549