[PATCH] D30313: [test-suite] Add regression test for indirect branch critical edge splitting

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 10:35:08 PST 2017


Sorry, I simply didn't realize we're aiming for 0.5s-1s.
The number really is completely arbitrary, I was aiming at an about 5s
runtime (on my machine :-), and this gave me ~3s (after the fix).

Are you ok with just lowering it by one order of magnitude, or would you
like actual time tracking (run in batches of, say, 1000 iterations until 1s
has passed)?

On Thu, Mar 2, 2017 at 10:28 AM, Matthias Braun via Phabricator <
reviews at reviews.llvm.org> wrote:

> MatzeB added a comment.
>
> Sorry to be this guy: This benchmark is running for too long! We should
> aim for 0.5-1s runtimes for our benchmarks and the `1000000` looks
> arbitrary to me. (This takes nearly 3x the time of salsa20, the next
> slowest benchmark in SingleSource/Benchmarks/Misc for me).
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D30313
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170302/7a943875/attachment.html>


More information about the llvm-commits mailing list