[PATCH] D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types

[David Blaikie via llvm-commits]

We'll probably want to add a generic function that can choose between
implicit_const and  a DWARF4 form - because we'll probably want to use
implicit_const for existing attributes (like accessibility, etc). How do we
handle form_present? I think we have a high level "add Flag" operation that
uses form_present or something backwards compatible depending on the target
DWARF verison)

On Tue, Feb 28, 2017 at 3:26 PM Paul Robinson via Phabricator <
reviews at reviews.llvm.org> wrote:

> probinson added inline comments.
>
>
> ================
> Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:973
> +    // Add DW_AT_calling_convention attr.
> +    if (DD->getDwarfVersion() >= 5) {
> +      auto ArgABI = CTy->getArgABI();
> ----------------
> aprantl wrote:
> > Technically true, but I think there is no harm in emitting this
> attribute also in DWARF 4 or earlier. We usually only do this if the new
> attribute cannot be safely ignored by an older consumer.
> Actually DW_FORM_implicit_const is new in DWARF 5, and new FORMs cannot be
> used in prior-version DIEs.  So, either we have to guard the entire
> attribute, or we have to conditionalize the FORM.
>
>
> https://reviews.llvm.org/D30377
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170301/38e09513/attachment.html>