[PATCH] D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:973
+    // Add DW_AT_calling_convention attr.
+    if (DD->getDwarfVersion() >= 5) {
+      auto ArgABI = CTy->getArgABI();
----------------
aprantl wrote:
> Technically true, but I think there is no harm in emitting this attribute also in DWARF 4 or earlier. We usually only do this if the new attribute cannot be safely ignored by an older consumer.
Actually DW_FORM_implicit_const is new in DWARF 5, and new FORMs cannot be used in prior-version DIEs.  So, either we have to guard the entire attribute, or we have to conditionalize the FORM.


https://reviews.llvm.org/D30377