[PATCH] D29092: PR31729: [GVNHoist] Don't hoist unsafe scalars at -Oz

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

In https://reviews.llvm.org/D29092#685017, @majnemer wrote:

> In https://reviews.llvm.org/D29092#682961, @hans wrote:
>
> > David, do you have any further concerns? Otherwise I'd like to see this committed so we can resolve the PR for 4.0.
>
>
> I don't understand why we cannot assert isSafeToSpeculativelyExecute if we are not in minsize. If we are given a call instruction, why do we think it is safe to hoist it?


A call without any side effects, for example, can be hoisted.


https://reviews.llvm.org/D29092