[PATCH] D29092: PR31729: [GVNHoist] Don't hoist unsafe scalars at -Oz

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

I am also no longer convinced the current fix is correct. Obviously memory SSA does not deal with all side effects necessary for the Div instruction or we wouldn't need this fix at all. I don't know whether that is by in the sense that memory SSA only deals with memory or if it should be considered a bug in memory SSA. In any case being conservative here in the face of bugs sounds like the right thing.

Please mention http://llvm.org/PR31729 in the commit message.


https://reviews.llvm.org/D29092