[PATCH] D29835: Correct register pressure calculation in presence of subregs

Alexander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 05:57:31 PST 2017


alex-t accepted this revision.
alex-t added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/RegisterPressure.cpp:43
+/// Clamp lane masks to maximum posible value.
+static void clampMasks(const MachineRegisterInfo &MRI, unsigned Reg,
+                       LaneBitmask& LaneMask1, LaneBitmask& LaneMask2) {
----------------
Given that getMaxLaneMaskForVReg returns all bit s that possibly can be set in the n=mask for given register class,  what is the purpose of the AND? Unless you expect the bits not present in the register class to be set in LaneMask for the reg unit of this class.


Repository:
  rL LLVM

https://reviews.llvm.org/D29835





More information about the llvm-commits mailing list