[PATCH] D28249: Improve scheduling with branch coalescing

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 11:32:31 PST 2017


echristo added a comment.

You marked things done that aren't done. What's going on? :)

-eric



================
Comment at: lib/CodeGen/BranchCoalescing.cpp:230
+///
+bool BranchCoalescing::analyzeBranch(CoalescingCandidateInfo &Cand) {
+  DEBUG(dbgs() << "Analyzing branch for block " << Cand.BranchBlock->getNumber()
----------------
lei wrote:
> echristo wrote:
> > Probably should be something like "canCoalesceBranch" instead of analyzeBranch. All of the analysis is being done by analyzeBranch really and this is actually figuring out whether or not we should coalesce.
> true
You've marked this done, but it's not done?


https://reviews.llvm.org/D28249





More information about the llvm-commits mailing list