[PATCH] D28249: Improve scheduling with branch coalescing

[Lei Huang via Phabricator via llvm-commits]

lei marked an inline comment as done.
lei added inline comments.


================
Comment at: lib/CodeGen/BranchCoalescing.cpp:289-303
+  for (MachineBasicBlock *Succ : Cand.BranchBlock->successors())
+    if (Succ != Cand.BranchTargetBlock) {
+      assert(Succ && "Expecting a valid fall-through block\n");
+
+      if (!Succ->empty()) {
+        DEBUG(dbgs() << "Fall-through block contains code -- skip\n");
+        return false;
----------------
echristo wrote:
> I believe the case you're looking for here is also whether or not there's a single fall through? Might be nice to reorganize the code with that in mind.
okay.


https://reviews.llvm.org/D28249