[PATCH] D29185: [lit] Allow llvm's build and test systems to support paths with spaces

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 11:39:07 PST 2017


chandlerc added a comment.

In https://reviews.llvm.org/D29185#677308, @mgorny wrote:

> I would like to point out that if you proactively reject all paths with spaces, you wouldn't be able to add additional tests that would test support for paths with spaces ;-). While I agree that we should avoid spaces whenever possible, I think it would be reasonable to add tests for paths with spaces wherever we expect them to be well-supported and want to avoid regressions.


You could add to lit's own tests a simple test tree under a path with a space and that would seem fine?

My goal is that *within* a lit test tree, the paths of the files that lit is walking don't have spaces.


https://reviews.llvm.org/D29185





More information about the llvm-commits mailing list