[PATCH] D29185: [lit] Allow llvm's build and test systems to support paths with spaces

[ben via Phabricator via llvm-commits]

bd1976llvm added a comment.

In https://reviews.llvm.org/D29185#677308, @mgorny wrote:

> I would like to point out that if you proactively reject all paths with spaces, you wouldn't be able to add additional tests that would test support for paths with spaces ;-). While I agree that we should avoid spaces whenever possible, I think it would be reasonable to add tests for paths with spaces wherever we expect them to be well-supported and want to avoid regressions.


True :) it would be hard to write explicit tests for paths with spaces.

An earlier reviewer suggested that we could modify one of the build bots to add a space in the path to the llvm source tree and the build directory. This would allow the support to be maintained without explicit tests.


https://reviews.llvm.org/D29185