[PATCH] D29775: [LLD] Add memory ORIGIN and LENGTH expression support

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Almost fine, a few nits.



================
Comment at: ELF/LinkerScript.cpp:1871
+    StringRef Name = readParenLiteral();
+    if (ScriptConfig->MemoryRegions.count(Name) == 0)
+      setError("memory region not defined: " + Name);
----------------
Do s/ScriptConfig/Opt/g

(Opt is an alias to ScriptConfig in this class.)


https://reviews.llvm.org/D29775