[PATCH] D29775: [LLD] Add memory ORIGIN and LENGTH expression support

[Robert Clarke via Phabricator via llvm-commits]

raidiun added a comment.

OK to use Opt in ifs at 1871 and 1877.
Using Opt in lambdas results in segfault. Presumably instance is gone by the time the lambda expressions are called. Could evaluate outside lambda expressions if preferred.
Similar pattern is used in lambdas for other commands (e.g. line 1868) accessing ScriptBase (LinkerScript.h:314).
ScriptBase->Opt may improve consistency but is currently private.


https://reviews.llvm.org/D29775