[PATCH] D28575: [CMake] Support externalizing debug info on non-Darwin platforms

[Chris Bieneman via Phabricator via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

A few small comments below. Otherwise LGTM.



================
Comment at: cmake/modules/AddLLVM.cmake:1400
   if(APPLE)
+    if(NOT LLVM_EXTERNALIZE_DEBUGINFO_SKIP_STRIP)
+      set(strip_command COMMAND xcrun strip -Sxl $<TARGET_FILE:${name}>)
----------------
This block should be unneeded because you're already setting strip_command above.


================
Comment at: cmake/modules/AddLLVM.cmake:1416
   else()
-    message(FATAL_ERROR "LLVM_EXTERNALIZE_DEBUGINFO isn't implemented for non-darwin platforms!")
+    if(NOT LLVM_EXTERNALIZE_DEBUGINFO_SKIP_STRIP)
+      set(strip_command COMMAND strip -gx $<TARGET_FILE:${name}>)
----------------
This also should be unneeded.


Repository:
  rL LLVM

https://reviews.llvm.org/D28575