[PATCH] D29732: [buildbot] Use CmakeCommand

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added inline comments.


================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:81-84
+    if extra_configure_args:
+        cmake_args = extra_configure_args[:]
+    else:
+        cmake_args = list()
----------------
rnk wrote:
> IMO this is more Python-y:
>   cmake_args = []
>   if extra_configure_args:
>       cmake_args = list(extra_configure_args)
> 
> I've always felt that using "[:]" to copy a list was confusing.
@rnk Ok, I agree.


https://reviews.llvm.org/D29732