[PATCH] D29472: PR31358: Add support for armv7ve triple in llvm.

[Manoj Gupta via Phabricator via llvm-commits]

manojgupta added a comment.

Hi Richard,

After making the changes you suggested, I am getting a test fail in build-attributes for cortex-r52 wrt Tag_Virtualization_use.
I noticed that cortex-r52 uses armv8-r arch model but armv8-r does not have TrustZone in its supported features. Is this correct ?
And if so, I can not add TrustZone to FeatureVirtualization sublist.

If TrustZone is indeed supported for  Armv8-r, I'll simply fix the test for cortex-r52.

def : ProcessorModel<"cortex-r52", CortexR52Model,      [ARMv8r, ProcR52,

  FeatureFPAO]>;

def ARMv8r    :  Architecture<"armv8-r",   "ARMv8r",   [HasV8Ops,

  FeatureRClass,
  FeatureDB,
  FeatureHWDiv,
  FeatureHWDivARM,
  FeatureT2XtPk,
  FeatureDSP,
  FeatureCRC,
  FeatureMP,
  FeatureVirtualization,  // No Trustzone in this list
  FeatureFPARMv8,
  FeatureNEON]>;

Failure details:

Before (ToT):
 .eabi_attribute 68, 2   @ Tag_Virtualization_use

After adding TrustZone:
 .eabi_attribute 68, 3   @ Tag_Virtualization_use

Thanks,
Manoj


Repository:
  rL LLVM

https://reviews.llvm.org/D29472