[PATCH] D29490: [ELF] - Use SignExtend when reading R_386_PC8 addend.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 08:13:11 PST 2017


George Rimar <grimar at accesssoftek.com> writes:

>>It is not clear how this could make a difference. The relocation is to
>>another section. You should alse be able to simplify the "foo-1f" to
>>just "foo - number", no?
>>
>>Cheers,
>>Rafael
>
> Sure, foo-2 I think should do the same. But it does not look so clear.
> 2 is like a magic number. Using label made it more readable.

Please use a number since that is the most direct way of creating the
addend.

Cheers,
Rafael


More information about the llvm-commits mailing list