[PATCH] D29490: [ELF] - Use SignExtend when reading R_386_PC8 addend.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 3 08:03:32 PST 2017

>It is not clear how this could make a difference. The relocation is to
>another section. You should alse be able to simplify the "foo-1f" to
>just "foo - number", no?

Sure, foo-2 I think should do the same. But it does not look so clear.
2 is like a magic number. Using label made it more readable.

(Actually that part was taken from original place with issue, they do the same:
http://lxr.free-electrons.com/source/arch/x86/boot/header.S#L292, I liked how it looks)

I'll simplify that then.


More information about the llvm-commits mailing list