[PATCH] D29200: [JumpThread] Enhance finding partial redundant loads by continuing scanning single predecessor
Daniel Berlin via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 2 07:32:39 PST 2017
I added comments to your review. I'm not sure why we are trying to make
jump threading do this, and the testcases added are already taken care of
by other passes ...
(those passes are also faster at it)
(So either we should have testcases that only jump threading can get, or we
shouldn't make jump threading more expensive to do this)
On Tue, Jan 31, 2017 at 9:12 AM, Renato Golin via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
> rengolin accepted this revision.
> rengolin added a comment.
> This revision is now accepted and ready to land.
> LGTM, thanks!
> Comment at: test/Transforms/JumpThreading/thread-loads.ll:326
> + %l2 = load i64, i64* %P
> + call void @fn2(i64 %l2)
> junbuml wrote:
> > rengolin wrote:
> > > Isn't there just one hop here? `%l2 -> %l1`?
> > >
> > > I thought you were testing multiple predecessors.
> > It's one hop from cond2 to entry, but cond2 -> cond1 -> entry is two hop.
> > I also added another test which has three hop.
> Right, now it makes more sense. Thanks!
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits