[PATCH] D29200: [JumpThread] Enhance finding partial redundant loads by continuing scanning single predecessor

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 09:12:58 PST 2017

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

Comment at: test/Transforms/JumpThreading/thread-loads.ll:326
+  %l2 = load i64, i64* %P
+  call void @fn2(i64 %l2)
junbuml wrote:
> rengolin wrote:
> > Isn't there just one hop here? `%l2 -> %l1`?
> > 
> > I thought you were testing multiple predecessors.
> It's one hop from cond2 to entry, but cond2 -> cond1 -> entry is two hop.
> I also added another test which has three hop. 
Right, now it makes more sense. Thanks!


More information about the llvm-commits mailing list