[PATCH] D29203: Change debug-info-for-profiling from a TargetOption to a function attribute.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.

I added one comment to the testcase, otherwise this is fine now.



================
Comment at: test/Bitcode/upgrade-debug-info-for-profiling.ll:8
+!llvm.dbg.cu = !{!1}
+; CHECK-NOT: DICompileUnit{{.*}} debugInfoForProfiling: true
+!1 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2, emissionKind: FullDebug)
----------------
Ah I didn't see the -NOT.
It is better to write this as 
CHECK: DICompileUnit(language: DW_LANG_C99, file: !{{[0-9]+]], emissionKind: FullDebug)
otherwise /bin/true would also pass this test.


https://reviews.llvm.org/D29203