[PATCH] D29203: Change debug-info-for-profiling from a TargetOption to a function attribute.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 08:02:58 PST 2017

danielcdh added inline comments.

Comment at: test/Bitcode/upgrade-debug-info-for-profiling.ll:13
+; CHECK: DICompileUnit{{.*}} debugInfoForProfiling: true
+!1 = distinct !DICompileUnit(language: DW_LANG_C99, file: !2, emissionKind: FullDebug, debugInfoForProfiling: true)
+!2 = !DIFile(filename: "foo.c", directory: "/path/to/dir")
aprantl wrote:
> Perhaps I'm confused about what this is testing*, but shouldn't the default be debugInfoForProfiling: false?
> *) I was expecting a DICompilieUnit produced by today's trunk without a bitcode record for the new flag, so we can verify that the old bitcode format is updated correctly.
Not sure if I understand what to test in this upgrade test.

What I did here:

1. build the .ll file with the current trunk without this patch to produce the .bc file
2. check "debugInfoForProfiling: true" does *not* exists in the llvm-dis output.

Am I doing the right thing?


More information about the llvm-commits mailing list