[PATCH] D28836: [tsan] Provide API for libraries for race detection on custom objects
Kuba (Brecka) Mracek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 1 05:43:17 PST 2017
kubamracek marked 4 inline comments as done.
kubamracek added a comment.
> 1. There is also a minor nit re u32 cast.
> 2. Why don't you call FuncEntry(caller_pc)/FuncExit(caller_pc) around the accesses?
I fixed both these in the last version of the patch.
FuncEntry/FuncExit does really improve the stacks, but it still doesn't solve all the problems, and I plan to discuss them later in upcoming patches. Sounds okay?
More information about the llvm-commits