[PATCH] D28836: [tsan] Provide API for libraries for race detection on custom objects

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 02:54:02 PST 2017

dvyukov added a comment.

In https://reviews.llvm.org/D28836#661771, @kubamracek wrote:

> Here's the output of the testcase from the patch (the "TEST3" scenario, which is the only one interesting).  The stacks have some C++'ish noise in them due to the use of std::thread.

Thanks! Looks good.

There is also a minor nit re u32 cast.

> Why don't you call FuncEntry(caller_pc)/FuncExit(caller_pc) around the accesses?

Is there a reason to not do this now? Looks simple to do and it should improve things.


More information about the llvm-commits mailing list