[PATCH] D27404: Make asan_symbolize.py py3-compatible

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 1 00:06:25 PST 2017

chapuni added inline comments.

Comment at: compiler-rt/trunk/lib/asan/scripts/asan_symbolize.py:106
+        print(symbolizer_input)
+      self.pipe.stdin.write("%s\n" % symbolizer_input)
       while True:
mgorny wrote:
> Not saying it's a problem but strictly speaking to preserve the original semantic, you could use:
>     print(symbolizer_input, file=self.pipe.stdin)
> + at the top:
>     from __future__ import print_function
> (with the latter being a good idea anyway)
I was not noticed __future__ when tweaking.

As Kostya says above, asan_symbolize will be obsoleted. I think it'd be trivial.



More information about the llvm-commits mailing list