[PATCH] D28964: [PGO] Value profile support for value ranges
Rong Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 30 16:21:50 PST 2017
xur marked an inline comment as done.
xur added a comment.
One reply to vsk's comment in inlined.
I'll add a test per vsk's suggestion. Patch description will also be updated when I upload the new patch.
Comment at: lib/profile/InstrProfilingValue.c:251
+ __llvm_profile_instrument_target(TargetValue, Data, CounterIndex);
> IIUC we get precise counts if TargetValue is in [PreciseRangeStart, PreciseRangeLast], or if LargeValue == INT64_MIN. If so, that doesn't seem quite right, because I thought you only wanted precise counts for in-range values.
I don't see a problem here: if LargeValue is INT64_MIN, we will go the second if in the else branch -- this collapse the out of range values.
More information about the llvm-commits