[llvm] r293551 - Re-commit AMDGPU/GlobalISel: Add support for simple shaders

[Mikael Holmén via llvm-commits]

On 01/31/2017 03:15 PM, Tom Stellard wrote:
> On Tue, Jan 31, 2017 at 02:29:40PM +0100, Mikael Holmén wrote:
>>
>>
>> On 01/31/2017 02:23 PM, Tom Stellard wrote:
>>> On Tue, Jan 31, 2017 at 08:53:24AM +0100, Mikael Holmén via llvm-commits wrote:
>>>> Hi Tom,
>>>>
>>>> The new test
>>>>
>>>> test/CodeGen/AMDGPU/GlobalISel/inst-select-load-smrd.mir
>>>>
>>>> in this commit fails for me:
>>>>
>>>> /data/repo/llvm-patch/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-smrd.mir:57:9:
>>>> error: expected string not found in input
>>>> # SIVI: [[ADD_PTR_LO:%[0-9]+]] = S_ADD_U32 [[PTR_LO]], [[K_SUB0]]
>>>>          ^
>>>> <stdin>:217:2: note: scanning from here
>>>>   %48 = COPY %19.sub0
>>>>   ^
>>>> <stdin>:217:2: note: with variable "PTR_LO" equal to "%47"
>>>>   %48 = COPY %19.sub0
>>>>   ^
>>>> <stdin>:217:2: note: with variable "K_SUB0" equal to "%56"
>>>>   %48 = COPY %19.sub0
>>>>   ^
>>>> <stdin>:241:2: note: possible intended match here
>>>>   %29 = S_ADDC_U32 %32, %33, implicit-def %scc, implicit %scc
>>>>   ^
>>>>
>>>> Looking at the generated output I see
>>>>
>>>>      %59 = S_MOV_B32 4294967292
>>>>      %60 = S_MOV_B32 3
>>>>      %16 = REG_SEQUENCE %59, 1, %60, 2
>>>>      %53 = S_ADD_U32 %55, %56, implicit-def %scc
>>>>      %55 = COPY %0.sub0
>>>>      %56 = COPY %16.sub0
>>>>
>>>> so the s_ADD_U32 using %55 and %56 is output before the COPY:s that
>>>> define %55 and %56?
>>>>
>>>> I just ran the test both on top-of-tree and exactly on commit r293551
>>>> and both fail.
>>>>
>>>> Anyone idea? I suppose it works for you so something fishy seems to be
>>>> going on.
>>>>
>>>
>>> Can you send me the full output?
>>
>> Attached both the mir output and "-print-before-all -print-after-all
>> -debug" printouts. Hope it helps.
>>
>
> It looks like the instructions are being inserted in a different order
> than on my local machine.  What CMake arguments are you using?

CC='/usr/bin/clang -march=corei7' CXX='/usr/bin/clang++ -march=corei7' 
LDFLAGS=-Wl,-R/usr/lib64 cmake -G Ninja 
-DCMAKE_MAKE_PROGRAM=/proj/flexasic/app/ninja/1.4/SLED11-64/bin/ninja 
-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON 
-DLLVM_ENABLE_WERROR=ON -DCMAKE_EXPORT_COMPILE_COMMANDS=ON ../.

>  Also if
> you delete your build directory and re-build, does that fix the issue?

No, I already did a complete clean build.

 > Also, can you try this patch? https://reviews.llvm.org/D29325
 >

Yes, that passed for me.

Regards,
Mikael

>
> -Tom
>