[llvm] r293551 - Re-commit AMDGPU/GlobalISel: Add support for simple shaders

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 06:18:34 PST 2017


On Tue, Jan 31, 2017 at 02:29:40PM +0100, Mikael Holmén wrote:
> 
> 
> On 01/31/2017 02:23 PM, Tom Stellard wrote:
> > On Tue, Jan 31, 2017 at 08:53:24AM +0100, Mikael Holmén via llvm-commits wrote:
> >> Hi Tom,
> >>
> >> The new test
> >>
> >> test/CodeGen/AMDGPU/GlobalISel/inst-select-load-smrd.mir
> >>
> >> in this commit fails for me:
> >>
> >> /data/repo/llvm-patch/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-smrd.mir:57:9:
> >> error: expected string not found in input
> >> # SIVI: [[ADD_PTR_LO:%[0-9]+]] = S_ADD_U32 [[PTR_LO]], [[K_SUB0]]
> >>          ^
> >> <stdin>:217:2: note: scanning from here
> >>   %48 = COPY %19.sub0
> >>   ^
> >> <stdin>:217:2: note: with variable "PTR_LO" equal to "%47"
> >>   %48 = COPY %19.sub0
> >>   ^
> >> <stdin>:217:2: note: with variable "K_SUB0" equal to "%56"
> >>   %48 = COPY %19.sub0
> >>   ^
> >> <stdin>:241:2: note: possible intended match here
> >>   %29 = S_ADDC_U32 %32, %33, implicit-def %scc, implicit %scc
> >>   ^
> >>
> >> Looking at the generated output I see
> >>
> >>      %59 = S_MOV_B32 4294967292
> >>      %60 = S_MOV_B32 3
> >>      %16 = REG_SEQUENCE %59, 1, %60, 2
> >>      %53 = S_ADD_U32 %55, %56, implicit-def %scc
> >>      %55 = COPY %0.sub0
> >>      %56 = COPY %16.sub0
> >>
> >> so the s_ADD_U32 using %55 and %56 is output before the COPY:s that
> >> define %55 and %56?
> >>
> >> I just ran the test both on top-of-tree and exactly on commit r293551
> >> and both fail.
> >>
> >> Anyone idea? I suppose it works for you so something fishy seems to be
> >> going on.
> >>
> >
> > Can you send me the full output?
> 
> Attached both the mir output and "-print-before-all -print-after-all 
> -debug" printouts. Hope it helps.
> 

Also, can you try this patch? https://reviews.llvm.org/D29325


-Tom


More information about the llvm-commits mailing list