[PATCH] D29321: [globalisel] Make the MatchAction hierarchy consistent with the matchers. NFC.

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 05:25:35 PST 2017

kristof.beyls added inline comments.

Comment at: utils/TableGen/GlobalISelEmitter.cpp:330
+    Actions.emplace_back(llvm::make_unique<Kind>(std::forward<Args>(args)...));
+    return *Actions.back();
+  }
The corresponding function addPredicate(Args&&... args) has the same implementation, except for this return statement:
    return *static_cast<Kind *>(Predicates.back().get());

Any reason why it needs to be different?


More information about the llvm-commits mailing list