[PATCH] D29321: [globalisel] Make the MatchAction hierarchy consistent with the matchers. NFC.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 31 03:06:09 PST 2017


dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:294
+
+class MutateOpcode : public MatchAction {
+private:
----------------
kristof.beyls wrote:
> For more consistency, maybe this class name should end in "Action", i.e. "MutateOpcodeAction"?
> All of the matcher sub-class names end in "Matcher".
I agree. I've updated the patch


https://reviews.llvm.org/D29321





More information about the llvm-commits mailing list