[PATCH] D29306: Expose isLegalToPromot as a global helper function so that SamplePGO pass can call it for legality check.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 14:37:36 PST 2017


davidxl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:233
+  TargetFunction = Symtab->getFunction(Target);
+  if (TargetFunction == nullptr) {
+    *Reason = "Cannot find the target";
----------------
why hoisting this into the caller?


https://reviews.llvm.org/D29306





More information about the llvm-commits mailing list