[PATCH] D29306: Expose isLegalToPromot as a global helper function so that SamplePGO pass can call it for legality check.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 14:33:11 PST 2017


danielcdh marked an inline comment as done.
danielcdh added inline comments.


================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:149
     OK,                   // Should be able to promote.
     NotAvailableInModule, // Cannot find the target in current module.
   };
----------------
davidxl wrote:
> Why keeping this one value but eliminating all the others?
forgot to delete the dead code...


https://reviews.llvm.org/D29306





More information about the llvm-commits mailing list