[PATCH] D28978: [ThinLTO] Add an auto-hide feature

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 14:20:23 PST 2017

pcc added a comment.

Does this need to be in the summary? I would have thought that the linker can use `canBeOmittedFromSymbolTable()` to implement its own auto-hiding logic. That is what ELF lld currently does.

Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:980
   RawFlags = (RawFlags << 4) | Flags.Linkage; // 4 bits
+  RawFlags |= (Flags.AutoHide << 6);         // bool
tejohnson wrote:
> Move this up and << 2 (consistent with LiveRoot and other bool flag setup)
It looks like we are setting this variable in a very confusing way. I'd move the linkage first and then shift NotEligibleToImport and LiveRoot by 4 more.


More information about the llvm-commits mailing list