[PATCH] D28978: [ThinLTO] Add an auto-hide feature

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:980
   RawFlags = (RawFlags << 4) | Flags.Linkage; // 4 bits
+  RawFlags |= (Flags.AutoHide << 6);         // bool
 
----------------
Move this up and << 2 (consistent with LiveRoot and other bool flag setup)


================
Comment at: llvm/lib/LTO/LTO.cpp:910
+          ExportedGUIDs.count(GUID)) {
+        if (GUIDPreservedSymbols.count(GUID))
+          return Exported;
----------------
Add TODO about distinguishing which are used in regular LTO partition vs outside LTO/IR.


================
Comment at: llvm/lib/LTO/ThinLTOCodeGenerator.cpp:900
+  auto GUIDCrossRefSymbols =
+      computeGUIDPreservedSymbols(CrossReferencedSymbols, TMBuilder.TheTriple);
 
----------------
Consider renaming this method


================
Comment at: llvm/test/ThinLTO/X86/weak_autohide.ll:4
+; RUN: opt -module-summary %p/Inputs/weak_autohide.ll -o %t2.bc
+; RUN: llvm-lto -thinlto-action=thinlink -o %t.index.bc %t1.bc %t2.bc
+
----------------
Unused


https://reviews.llvm.org/D28978