[PATCH] D29281: [docs] cleanup documentation on lit substitutions

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 08:38:56 PST 2017

bd1976llvm added inline comments.

Comment at: docs/TestingGuide.rst:474
+  Act like the corresponding substitution above but replace any ``\``
+  character with a ``/``. This is useful to normalize path separators.
bd1976llvm wrote:
> rengolin wrote:
> > From the old doc, it seems to be the other way round.
> I think that the new doc is correct. From the source code:     
> # "%/[STpst]" should be normalized.
>     substitutions.extend([
>             ('%/s', escapedSourcePath.replace('\\', '/')),
Well that came out badly :( The key point is that the code does this: replace('\\', '/')


More information about the llvm-commits mailing list