[PATCH] D29281: [docs] cleanup documentation on lit substitutions

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 30 08:38:07 PST 2017


bd1976llvm added inline comments.


================
Comment at: docs/TestingGuide.rst:474
+  Act like the corresponding substitution above but replace any ``\``
+  character with a ``/``. This is useful to normalize path separators.
+
----------------
rengolin wrote:
> From the old doc, it seems to be the other way round.
I think that the new doc is correct. From the source code:     
# "%/[STpst]" should be normalized.
    substitutions.extend([
            ('%/s', escapedSourcePath.replace('\\', '/')),


================
Comment at: docs/TestingGuide.rst:488
+
+   Example: ``%:s: C\Desktop Files\foo_test.s.tmp``
+
----------------
rengolin wrote:
> I had no idea this worked at all! Then again, last time I used Windows was when it was still being launched from DOS.
You have no idea what your missing out on :)


https://reviews.llvm.org/D29281





More information about the llvm-commits mailing list