[PATCH] D29170: [ELF] - Remove unnessesary checks from GC logic.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 23:50:06 PST 2017


>> https://reviews.llvm.org/D28612 adds SHT_RELA and SHT_REL sections that should be involved in GC (because .rela.text depends on .text and we do not want to keep REL[A] >sections unconditionally).
>> REL[A] sections are not SHF_ALLOC, that means I need to set up GC logic for them.>
>
>That is the fundamental change I think. Right now we don't gc non alloc
>sections. It would probably be better to split the patches is the other
>order:
>
>* Make --emit-relocs work without --gc-sections.
>* Add --gc-sections support.
>
>That way each patch is fixing or implementing something and we don't
>have a discussion on something being a cleanup or not.
>
>Cheers,
>Rafael

Ok, I am going to split the patches then in according to what you suggesting.
I will restrict using --gc-sections and --emit-relocs for first patch. Anyways by the way it is not the case I am fixing in kernel,
it just should proccess "/DISCARD"/ correctly, --gc-sections was not involved there.

George.


More information about the llvm-commits mailing list