[PATCH] D29170: [ELF] - Remove unnessesary checks from GC logic.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 27 11:01:03 PST 2017


George Rimar via Phabricator <reviews at reviews.llvm.org> writes:


> https://reviews.llvm.org/D28612 adds SHT_RELA and SHT_REL sections that should be involved in GC (because .rela.text depends on .text and we do not want to keep REL[A] sections unconditionally). 
> REL[A] sections are not SHF_ALLOC, that means I need to set up GC logic for them.

That is the fundamental change I think. Right now we don't gc non alloc
sections. It would probably be better to split the patches is the other
order:

* Make --emit-relocs work without --gc-sections.
* Add --gc-sections support.

That way each patch is fixing or implementing something and we don't
have a discussion on something being a cleanup or not.

Cheers,
Rafael


More information about the llvm-commits mailing list