[PATCH] D28476: [Analysis] Add LF_ prefix to LibFunc enums in TargetLibraryInfo. (NFC)

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 15:04:48 PST 2017

dlj added a comment.

Not really... musl-libc is conforming, and the assumption that "memmove" is a valid token has different reasoning than that for "fopen64" (i.e., one is allowed by the C++ standard, the other is not).

(On a side note, I'm not sure #undef is a reasonable approach for any libc implementation, but in this particular case Clang is broken with a perfectly conformant libc. So that seems worthwhile to fix.)


More information about the llvm-commits mailing list