[PATCH] D28476: [Analysis] Add LF_ prefix to LibFunc enums in TargetLibraryInfo. (NFC)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 13:27:04 PST 2017

efriedma added a comment.

> However, there are some "library"functions which are not part of the standard, and thus not subject to this rule (fopen64, for example). So, in order to be both portable and consistent, the enum should not use the bare function names.

Generally, our response to system headers which contain stupid `#define`s is just to `#undef` them.  (See, for example, include/llvm/ADT/Triple.h.)  Would that be practical in your situation?


More information about the llvm-commits mailing list