[LNT] r292610 - Make lnt runtest test-suite not stop on build failures in the tests.

[Chris Matthews via llvm-commits]

Thanks! This has been annoying me for a while!  This matches the behavior of the NT runner, and will let us keep running the other tests when one does not build (very common)!


On January 20, 2017 at 6:24:44 AM, Kristof Beyls via llvm-commits (llvm-commits at lists.llvm.org) wrote:

Author: kbeyls
Date: Fri Jan 20 08:13:32 2017
New Revision: 292610

URL: http://llvm.org/viewvc/llvm-project?rev=292610&view=rev
Log:
Make lnt runtest test-suite not stop on build failures in the tests.


Modified:
lnt/trunk/lnt/tests/test_suite.py
lnt/trunk/tests/runtest/test_suite.py

Modified: lnt/trunk/lnt/tests/test_suite.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/test_suite.py?rev=292610&r1=292609&r2=292610&view=diff
==============================================================================
--- lnt/trunk/lnt/tests/test_suite.py (original)
+++ lnt/trunk/lnt/tests/test_suite.py Fri Jan 20 08:13:32 2017
@@ -671,9 +671,15 @@ class TestSuiteTest(BuiltinTest):
args = ["VERBOSE=1", target]
else:
args = [target]
- self._check_call([make_cmd,
- '-j', str(self._build_threads())] + args,
- cwd=subdir)
+ try:
+ self._check_call([make_cmd,
+ '-k', '-j', str(self._build_threads())] + args,
+ cwd=subdir)
+ except subprocess.CalledProcessError:
+ # make is expected to exit with code 1 if there was any build
+ # failure. Build failures are not unexpected when testing an
+ # experimental compiler.
+ pass

def _lit(self, path, test):
lit_cmd = self.opts.lit

Modified: lnt/trunk/tests/runtest/test_suite.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/tests/runtest/test_suite.py?rev=292610&r1=292609&r2=292610&view=diff
==============================================================================
--- lnt/trunk/tests/runtest/test_suite.py (original)
+++ lnt/trunk/tests/runtest/test_suite.py Fri Jan 20 08:13:32 2017
@@ -247,7 +247,7 @@
# CHECK-ONLYTEST: Configuring with {
# CHECK-ONLYTEST: one: 'two'
# CHECK-ONLYTEST: three: 'four'
-# CHECK-ONLYTEST: Execute: {{.*}}/fake-make -j 1 VERBOSE=1 subtest
+# CHECK-ONLYTEST: Execute: {{.*}}/fake-make -k -j 1 VERBOSE=1 subtest

# Check --benchmarking-only
# RUN: lnt runtest test-suite \


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170120/ec9386b3/attachment.html>