<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Thanks! This has been annoying me for a while! This matches the behavior of the NT runner, and will let us keep running the other tests when one does not build (very common)!</div> <br> <div id="bloop_sign_1484933390382729984" class="bloop_sign"></div> <br><p class="airmail_on">On January 20, 2017 at 6:24:44 AM, Kristof Beyls via llvm-commits (<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>Author: kbeyls<br>Date: Fri Jan 20 08:13:32 2017<br>New Revision: 292610<br><br>URL: http://llvm.org/viewvc/llvm-project?rev=292610&view=rev<br>Log:<br>Make lnt runtest test-suite not stop on build failures in the tests.<br><br><br>Modified:<br> lnt/trunk/lnt/tests/test_suite.py<br> lnt/trunk/tests/runtest/test_suite.py<br><br>Modified: lnt/trunk/lnt/tests/test_suite.py<br>URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/test_suite.py?rev=292610&r1=292609&r2=292610&view=diff<br>==============================================================================<br>--- lnt/trunk/lnt/tests/test_suite.py (original)<br>+++ lnt/trunk/lnt/tests/test_suite.py Fri Jan 20 08:13:32 2017<br>@@ -671,9 +671,15 @@ class TestSuiteTest(BuiltinTest):<br> args = ["VERBOSE=1", target]<br> else:<br> args = [target]<br>- self._check_call([make_cmd,<br>- '-j', str(self._build_threads())] + args,<br>- cwd=subdir)<br>+ try:<br>+ self._check_call([make_cmd,<br>+ '-k', '-j', str(self._build_threads())] + args,<br>+ cwd=subdir)<br>+ except subprocess.CalledProcessError:<br>+ # make is expected to exit with code 1 if there was any build<br>+ # failure. Build failures are not unexpected when testing an<br>+ # experimental compiler.<br>+ pass<br> <br> def _lit(self, path, test):<br> lit_cmd = self.opts.lit<br><br>Modified: lnt/trunk/tests/runtest/test_suite.py<br>URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/tests/runtest/test_suite.py?rev=292610&r1=292609&r2=292610&view=diff<br>==============================================================================<br>--- lnt/trunk/tests/runtest/test_suite.py (original)<br>+++ lnt/trunk/tests/runtest/test_suite.py Fri Jan 20 08:13:32 2017<br>@@ -247,7 +247,7 @@<br> # CHECK-ONLYTEST: Configuring with {<br> # CHECK-ONLYTEST: one: 'two'<br> # CHECK-ONLYTEST: three: 'four'<br>-# CHECK-ONLYTEST: Execute: {{.*}}/fake-make -j 1 VERBOSE=1 subtest<br>+# CHECK-ONLYTEST: Execute: {{.*}}/fake-make -k -j 1 VERBOSE=1 subtest<br> <br> # Check --benchmarking-only<br> # RUN: lnt runtest test-suite \<br><br><br>_______________________________________________<br>llvm-commits mailing list<br>llvm-commits@lists.llvm.org<br>http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br></div></div></span></blockquote></body></html>