Friedman, Eli via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 19 11:09:14 PST 2017
On 1/18/2017 11:21 PM, Jonas Paulsson wrote:
>> This is a little confusing, but I wouldn't call it a bug. We
>> consistently call CustomLowerNode with the illegal type, whether it's
>> the result or an operand, and existing targets depend on that.
> Aha - that's a bit confusing, but thanks for explaining! I think a
> comment on this would be useful -- see my attached proposal for it.
/// Indicate that the specified operation does not work with the specified
- /// type and indicate what to do about it.
+ /// type and indicate what to do about it. Note that VT may refer to either
+ /// the type of the result or that of an operand of Op.
I would say "the type of a result", since some operations have multiple
results... but sure, looks fine.
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
More information about the llvm-commits