[PATCH] D27962: Get function start line number from DWARF info

[Eric Christopher via llvm-commits]

I agree. I'd rather not have unused code in tree - let's get something
useful in llvm-symbolizer to keep the information around.

-eric

On Tue, Jan 17, 2017 at 2:43 PM Simon Que <sque at google.com> wrote:

> We could update DIPrinter, which is being used by LLVM symbolizer to print
> all the info. That should be relatively simple.
>
> On Tue, Jan 17, 2017 at 2:17 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
>
> On Tue, Jan 17, 2017 at 2:10 PM Simon Que via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
> sque added a comment.
>
> In https://reviews.llvm.org/D27962#647456, @dblaikie wrote:
>
> > Also - what's the use case for this? (& test coverage would be
> good/necessary)
>
>
> Use case: Internal use case, will email you about it.
>
>
> Would it be possible to motivate these changes with improvements to
> llvm-symbolizer (since we use that internally, seems like maybe
> improvements to internal symbolication things might be good to have in
> llvm-symbolizer too & that'd make it easier to carry these changes upstream
> (since then regressions would be more obvious and other developers would
> have a stronger motivation/demonstration of the value/need for these
> features))?
>
> Don't want to sign you up for lots of work, but can be a bit tricky
> carrying unused code upstream like this.
>
> (perhaps Eric can weigh in on what he's got/had in mind here)
>
>
>
> Unit test: No unit test exists for DWARFContext, but I added one here,
> awaiting review: https://reviews.llvm.org/D28428
>
> (Both are already mentioned earlier in this thread)
>
>
> https://reviews.llvm.org/D27962
>
>
>
>
>
>
> --
> Simon Que
> Software Engineer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170118/e8ba3303/attachment.html>