<div dir="ltr">I agree. I'd rather not have unused code in tree - let's get something useful in llvm-symbolizer to keep the information around.<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jan 17, 2017 at 2:43 PM Simon Que <<a href="mailto:sque@google.com">sque@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">We could update DIPrinter, which is being used by LLVM symbolizer to print all the info. That should be relatively simple.</div><div class="gmail_extra gmail_msg"></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Tue, Jan 17, 2017 at 2:17 PM, David Blaikie <span dir="ltr" class="gmail_msg"><<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><span class="gmail_msg"><div dir="ltr" class="gmail_msg">On Tue, Jan 17, 2017 at 2:10 PM Simon Que via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="gmail_msg" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sque added a comment.<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
In <a href="https://reviews.llvm.org/D27962#647456" rel="noreferrer" class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D27962#647456</a>, @dblaikie wrote:<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
> Also - what's the use case for this? (& test coverage would be good/necessary)<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
Use case: Internal use case, will email you about it.<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg"></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></span><div class="gmail_msg">Would it be possible to motivate these changes with improvements to llvm-symbolizer (since we use that internally, seems like maybe improvements to internal symbolication things might be good to have in llvm-symbolizer too & that'd make it easier to carry these changes upstream (since then regressions would be more obvious and other developers would have a stronger motivation/demonstration of the value/need for these features))?<br class="gmail_msg"><br class="gmail_msg">Don't want to sign you up for lots of work, but can be a bit tricky carrying unused code upstream like this.<br class="gmail_msg"><br class="gmail_msg">(perhaps Eric can weigh in on what he's got/had in mind here)</div><span class="gmail_msg"><div class="gmail_msg"> </div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
Unit test: No unit test exists for DWARFContext, but I added one here, awaiting review: <a href="https://reviews.llvm.org/D28428" rel="noreferrer" class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D28428</a><br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
(Both are already mentioned earlier in this thread)<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<a href="https://reviews.llvm.org/D27962" rel="noreferrer" class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D27962</a><br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
<br class="m_2173441797033119955m_-138398630743351226gmail_msg gmail_msg">
</blockquote></span></div></div>
</blockquote></div><br class="gmail_msg"><br clear="all" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg">-- <br class="gmail_msg"><div class="m_2173441797033119955gmail_signature gmail_msg" data-smartmail="gmail_signature"><div dir="ltr" class="gmail_msg">Simon Que<div class="gmail_msg">Software Engineer</div></div></div>
</div></blockquote></div>