[PATCH] D27990: [Thumb] Add support for tMUL in the compare instruction peephole optimizer
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 16 08:22:13 PST 2017
SjoerdMeijer updated this revision to Diff 84559.
SjoerdMeijer added a comment.
Thanks for reviewing again. I have fixed the typos in the comments, changed the variable name, and modified the test case. Regarding the predicated MOVs I have taken a slightly different approach. Since we only want to do this peephole optimisation for Thumb1, I first check that the instruction is actually a Thumb1 instruction. And because Thumb1 does not have conditional movs, we can safely omit the isPredicated check (testing shows no issues).
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 18701 bytes
Desc: not available
More information about the llvm-commits