[PATCH] D27990: [Thumb] Add support for tMUL in the compare instruction peephole optimizer

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 04:44:44 PST 2017

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

LGTM with a couple more nitpicks (you don't have to upload a new version here, just make the changes and commit).

Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:2570
+  // the sequence into: MOVS, MOVS, MULS, CMP. So we do this reordering, and
+  // then continue the analysis hoping we can eleminate the CMP.
+  if (MI && IsThumb1) {
Another typo: eliminate :D

Comment at: test/CodeGen/ARM/cmp2-peephole-thumb.mir:8
Please move this closer to the MIR code (as you did for the other test), and also check for the compare.


More information about the llvm-commits mailing list