[PATCH] D28532: Revert rL291205 because it breaks Chrome tests under CFI.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 10 14:07:10 PST 2017


Can you send repro instructions?

LGTM with that.

Peter

On Jan 10, 2017 2:03 PM, "Ivan Krasin via Phabricator" <
reviews at reviews.llvm.org> wrote:

> krasin created this revision.
> krasin added a reviewer: pcc.
> krasin added a subscriber: llvm-commits.
> Herald added a subscriber: mehdi_amini.
>
> Revert LowerTypeTests: Split the pass in two: a resolution phase and a
> lowering phase.
>
> This change separates how type identifiers are resolved from how intrinsic
> calls are lowered. All information required to lower an intrinsic call
> is stored in a new TypeIdLowering data structure. The idea is that this
> data structure can either be initialized using the module itself during
> regular LTO, or using the module summary in ThinLTO backends.
>
> Original URL: https://reviews.llvm.org/D28341
>
>
> https://reviews.llvm.org/D28532
>
> Files:
>   include/llvm/Transforms/IPO/LowerTypeTests.h
>   lib/Transforms/IPO/LowerTypeTests.cpp
>   test/Transforms/LowerTypeTests/function-disjoint.ll
>   test/Transforms/LowerTypeTests/function-ext.ll
>   test/Transforms/LowerTypeTests/function.ll
>   test/Transforms/LowerTypeTests/import-unsat.ll
>   test/Transforms/LowerTypeTests/simple.ll
>   test/Transforms/LowerTypeTests/single-offset.ll
>   test/Transforms/LowerTypeTests/unsat.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170110/a608c257/attachment.html>


More information about the llvm-commits mailing list