<div dir="auto">Can you send repro instructions?<div dir="auto"><br></div><div dir="auto">LGTM with that.</div><div dir="auto"><br></div><div dir="auto">Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Jan 10, 2017 2:03 PM, "Ivan Krasin via Phabricator" <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">krasin created this revision.<br>
krasin added a reviewer: pcc.<br>
krasin added a subscriber: llvm-commits.<br>
Herald added a subscriber: mehdi_amini.<br>
<br>
Revert LowerTypeTests: Split the pass in two: a resolution phase and a lowering phase.<br>
<br>
This change separates how type identifiers are resolved from how intrinsic<br>
calls are lowered. All information required to lower an intrinsic call<br>
is stored in a new TypeIdLowering data structure. The idea is that this<br>
data structure can either be initialized using the module itself during<br>
regular LTO, or using the module summary in ThinLTO backends.<br>
<br>
Original URL: <a href="https://reviews.llvm.org/D28341" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D28341</a><br>
<br>
<br>
<a href="https://reviews.llvm.org/D28532" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D28532</a><br>
<br>
Files:<br>
  include/llvm/Transforms/IPO/<wbr>LowerTypeTests.h<br>
  lib/Transforms/IPO/<wbr>LowerTypeTests.cpp<br>
  test/Transforms/<wbr>LowerTypeTests/function-<wbr>disjoint.ll<br>
  test/Transforms/<wbr>LowerTypeTests/function-ext.ll<br>
  test/Transforms/<wbr>LowerTypeTests/function.ll<br>
  test/Transforms/<wbr>LowerTypeTests/import-unsat.ll<br>
  test/Transforms/<wbr>LowerTypeTests/simple.ll<br>
  test/Transforms/<wbr>LowerTypeTests/single-offset.<wbr>ll<br>
  test/Transforms/<wbr>LowerTypeTests/unsat.ll<br>
<br>
</blockquote></div></div>