[PATCH] D28312: NewGVN: Fix PR 31501.

[Daniel Berlin via Phabricator via llvm-commits]

dberlin marked 3 inline comments as done.
dberlin added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp:1870
 }
-
 bool NewGVN::eliminateInstructions(Function &F) {
----------------
davide wrote:
> Any reason why you removed this newline?
fixed


================
Comment at: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp:1998-1999
           }
-          if (Member && isa<Constant>(Member))
-            assert(isa<Constant>(CC->RepLeader));
 
----------------
davide wrote:
> Why this assertion doesn't hold anymore?
  if (isa<ConstantExpression>(E))
        assert(isa<Constant>(EClass->RepLeader) &&
               "Any class with a constant expression should have a "
               "constant leader");


verifies it now during congruence finding


Repository:
  rL LLVM

https://reviews.llvm.org/D28312